Yeah, the guy who wrote it and the guy who signed of on it probably know
that particular code better than I. But a fixed value in a code bock,
buried only god knows how deep in a source file is not good practice. A
const would have been better, but I wonder how important that check really
is. Is that code even needed ?
On Wed, Jun 15, 2016 at 8:34 AM, Robert Nelson <robertcnel...@gmail.com>
wrote:
> On Wed, Jun 15, 2016 at 10:33 AM, William Hermans <yyrk...@gmail.com>
> wrote:
> > card->ext_csd.rev = ext_csd[EXT_CSD_REV];
> > - if (card->ext_csd.rev > 6) {
> > + if (card->ext_csd.rev > 7) {
> > pr_err("%s: unrecognised EXT_CSD revision %d\n",
> > mmc_hostname(card->host), card->ext_csd.rev);
> > err = -EINVAL;
> >
> > Dare I ask who wrote that code ?
>
> atleast that "mess" was fixed in:
>
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/core?id=03a59437ef6b6ad7fb0165cb9b96c08d6bf057fc
>
> with an explanation..
>
> but yeah, not forward thinking at all..
>
> Regards,
>
> --
> Robert Nelson
> https://rcn-ee.com/
>
> --
> For more options, visit http://beagleboard.org/discuss
> ---
> You received this message because you are subscribed to the Google Groups
> "BeagleBoard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to beagleboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/beagleboard/CAOCHtYgkB258QUhShXpY74jXE7S8qy8owXXzazLweAqGDEXtKA%40mail.gmail.com
> .
> For more options, visit https://groups.google.com/d/optout.
>
--
For more options, visit http://beagleboard.org/discuss
---
You received this message because you are subscribed to the Google Groups
"BeagleBoard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to beagleboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/beagleboard/CALHSORrbtwUmA02RTZKCwTWQNqmLs-sQc5ud1F%2BZDQywB0hkSQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
