Ciao Daniele,

On Thu, Jan 17, 2019 at 04:19:14PM -0700, Daniele Nicolodi wrote:
> I found some time to hack on beancount-mode. You can find the progress
> here
> https://bitbucket.org/daniele/beancount/src/default/editors/emacs/beancount.el

great work! thanks a lot for this, more detailed feedback below.

> On 04/01/2019 06:25, Stefano Zacchiroli wrote:
> > - completion: I'm not sure how that is supposed to work. beancount-tab
> >   as a function works well for accounts and tags (but not metadata
> >   key/values, apparently), but if I bind it to TAB I lose indentation,
> >   whereas in ledger-mode the two seems to work well together. Maybe I'm
> >   not using it right
> > 
> > - indentation: as above, is there a function to auto-indent the first
> >   character of the current line at the right column that I'm not
> >   finding? in ledger-mode that's TAB, similarly to what happens with
> >   most other major modes for programming languages
> 
> Those two points have been fixed following Stefan advice. It works for
> me using fundamental-mode as major mode. I haven't implemented
> completion of metadata yet.

Account completion works perfectly for me now. Ditto for indentation.

The only glitch I've noticed is in the interaction between the two.
Consider the case of a badly indented line: you hit TAB on it and it
gets properly indented, if you hit TAB *again*, it will most often
triggers account completion (e.g., when you're on a account line),
generally overwriting the previous account name, which is generally not
what you want.

I've compared with the ledger-mode UX, and I think the key difference is
that in ledger-mode account completion is triggered only when the cursor
is at the end of the account name, not when it is anywhere else on an
account line. I haven't checked how that is actually detected in the
implementation though. I think it would make sense to do the same in
beancount-mode.

> > - highlighting: there's no highlighting of the current entry (usually a
> >   transaction), arguably a very minor point, but annoying when you're
> >   editing transactions with many postings/tags/metadata
> 
> This was easy to implement. You need something like
> 
> (setq beancount-highlight-transaction-at-point t)

This works perfectly.

Thanks a lot Daniele!,
hope this feedback helps,
Cheers
-- 
Stefano Zacchiroli . z...@upsilon.cc . upsilon.cc/zack . . o . . . o . o
Computer Science Professor . CTO Software Heritage . . . . . o . . . o o
Former Debian Project Leader & OSI Board Director  . . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

-- 
You received this message because you are subscribed to the Google Groups 
"Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to beancount+unsubscr...@googlegroups.com.
To post to this group, send email to beancount@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/beancount/20190119160905.ghll7axvsdlgjn2k%40upsilon.cc.
For more options, visit https://groups.google.com/d/optout.

Reply via email to