[ 
https://issues.apache.org/jira/browse/BIGTOP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205797#comment-13205797
 ] 

Bruno Mahé commented on BIGTOP-12:
----------------------------------

Great start! Thank you very much for taking care of this ticket.
I know this is a work in progress but some notes:
* I see a lot of references to hive even in files where occurrences have been 
replaced (see @HIVE_DAEMON@ in 
bigtop-packages/src/common/hcatalog/hcat_server.sh for instance)
* typo: +HIVE_USER="hcatalgo"
* I don't see the python parameter being used in the install script
* in bigtop-packages/src/deb/hcatalog/hcatalog.postinst, no need to create the 
warehouse manually. There is now a script to do that. But we should not do 
these calls at configure time anyway. We cannot assume there is a hadoop 
cluster running and in some cases, may even create a /user/hive/warehouse on 
local filesystem. The metastore rename can also be removed since there is no 
upgrade from any previous version (but I guess this is a left over the original 
hive files used as a template)
* No need for the "+Obsoletes: %{name}-webinterface" in the spec file
* No need to require hadoop >= 0.20.2 in the spec file since Apache bigtop has 
never provided a version less than 0.20.2
* I see hcatalog providing a hive binary. Is this on purpose or a work in 
progress? IF so, it should conflicts with hive package
* In the install script, I see you are moving hcat binary to /usr/bin/. How 
does that work regarding JAVA_HOME? Is there any need to write a wrapper script 
to source hcatalog default file and bigtop-utils' java home autodetection 
script?

Again, thank you very much!
                
> Add HCatalog to Bigtop
> ----------------------
>
>                 Key: BIGTOP-12
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-12
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Jolly Chen
>            Assignee: Giridharan Kesavan
>             Fix For: 0.3.0
>
>         Attachments: hcatalog.patch
>
>
> adding HCatalog http://incubator.apache.org/hcatalog/ would enhance the 
> Bigtop platform
> for post 0.1.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to