[
https://issues.apache.org/jira/browse/BIGTOP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461025#comment-13461025
]
Bruno Mahé commented on BIGTOP-12:
----------------------------------
Took a look at the latest patch and some comments:
* The man page does not have any mention of _Apache_ or _incubating_ for
projects
* The default file should not export HIVE_HOME or HIVE_CONF
* Let's not add more work to Anatoli. Could you separate $PREFIX from the other
variables in the install script? See his recent patches for exemples
* In the control file, Maintainer should be _Apache Bigtop_, not just _Bigtop_
* Shouldn't the copyright file mention that Apache HCatalog (incubating) is in
incubation (see the filed upstream-name)?
* postinst script has a typo: {quote}# postinst script for hcatalot{quote}
* preinst script has the following line: {noformat}# workaround for
https://issues.cloudera.org/browse/DISTRO-223{noformat}. I am not sure to see
the relationship with pig conf dir's symlink.
* The spec file defines _hadoop_username_ but I don't see it used anywhere.
Please delete that line if it is not used.
* In the spec file, are you sure you want to comment the following line 30:
{noformat}#%global initd_dir %{_sysconfdir}/rc.d/init.d{noformat} ? I also
don't see any init script for Apache HCatalog (incubating) server (it would
also need some user to be created)
* If the wrapper script for Apache Hcatalog (incubating) sources
/etc/default/hadoop, that means that the hadoop package should be a dependency
Other than that, it looks nice!
> Add HCatalog to Bigtop
> ----------------------
>
> Key: BIGTOP-12
> URL: https://issues.apache.org/jira/browse/BIGTOP-12
> Project: Bigtop
> Issue Type: Improvement
> Components: General
> Affects Versions: 0.1.0
> Reporter: Jolly Chen
> Assignee: Giridharan Kesavan
> Fix For: 0.3.0, 0.5.0
>
> Attachments: BIGTOP-12-V1.PATCH, BIGTOP-12-V2.PATCH,
> BIGTOP-12-V3.PATCH, BIGTOP-12-V4.PATCH, hcatalog.patch
>
>
> adding HCatalog http://incubator.apache.org/hcatalog/ would enhance the
> Bigtop platform
> for post 0.1.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
