On 1/24/2013 7:44 PM, Armin K. wrote:
> A few comments below:
>
> On 01/25/2013 01:48 AM, [email protected] wrote:
>> - <para><parameter>--disable-libxml</parameter>: This parameter
>> + <para><option>--disable-libxml</option>: This option
>> allows building PHP without <application>libxml2</application>
>> installed.</para>
>>
>
> I'd like to know how do you know when to use option or parameter. On
> this one you are changing parameter to option, while below you are
> changing option to parameter.
The Editor's Guide lays it out precisely. Parameter is used for switches that
are actually used in the instructions. Option is used for things that are
optional and are not actually in the instructions, only there to let readers
know something. It is easy when you think about it.
> Just curious. I was always using template/template.xml for that case.
I made that template years ago. If I recall correctly, there was an example
parameter and an example option. They were there so there would be one of each
as a reminder to other editors.
>> Modified: trunk/BOOK/general/sysutils/bluez.xml
>> ==============================================================================
>> --- trunk/BOOK/general/sysutils/bluez.xml Thu Jan 24 08:36:58 2013
>> (r10972)
>> +++ trunk/BOOK/general/sysutils/bluez.xml Thu Jan 24 16:48:47 2013
>> (r10973)
>> @@ -82,7 +82,7 @@
>> <para role="optional">
>> <xref linkend="alsa-lib"/>,
>> <xref linkend="check"/>,
>> - <xref linkend="cups"/>,
>> + <!-- <xref linkend="cups"/>, -->
>
> Why did you comment out Cups? It is used for CUPS bluetooth backend.
No, it is not. Cups is not used by the package. It does create the backend
but does not link anything from cups to it. In fact if you see the description
of the option in Command Explanations you will see that I mention that CUPS
need not be installed.
> Now that you pointed it out, I've checked it again, and it is correct.
> Also, same applies for --enable-alsa. You could just remove all of the
> code instead of commenting it out. Keeps files cleaner.
I prefer to comment out stuff the first time around. That way if there is a
screw up, it is much easier to put it back. It can always be deleted later.
Having commented code in the .xml files is still "clean".
>> <bridgehead renderas="sect4">Optional (Required for the
>> testsuite)</bridgehead>
>> <para role="optional">
>> - <xref linkend="gjs"/> and
>> + <xref linkend="gjs"/>,
>> + <xref linkend="dbus-python"/> and
>> <xref linkend="pygobject3"/>
>> </para>
>>
>
> Not important, but I guess it would be nice if you sorted it
> alphabeticaly as I did for every other package in GNOME.
Some are, some aren't. I typically try to but that must have slipped by.
>> <para>
>> - To test the results, issue: <command>make check</command>.
>> + To test the results, issue: <command>make -k check</command>. The
>> + JavaScript tests fail for unknown reasons.
>> </para>
>>
>
> This is strange. All tests passed on my side. You need to run them from
> a GUI though.
I did. Here is what I got:
TEST: test-paths... (pid=25936)
/service/search-for-paths: OK
/service/search-for-paths-async: OK
/service/search-for-paths-nulls: OK
/service/secret-for-path-sync: FAIL
GTester: last random seed: R02Sf02a5437bf3546297a237943635feab3
make[4]: *** [test-c] Terminated
TEST: test-lookup-password.py
EE..
======================================================================
ERROR: testAsyncNotFound (__main__.TestLookup)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test-lookup-password.py", line 58, in testAsyncNotFound
loop = GLib.MainLoop(None, False)
TypeError: function takes at most 0 arguments (2 given)
======================================================================
ERROR: testAsynchronous (__main__.TestLookup)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test-lookup-password.py", line 45, in testAsynchronous
loop = GLib.MainLoop(None, False)
TypeError: function takes at most 0 arguments (2 given)
----------------------------------------------------------------------
Ran 4 tests in nans
FAILED (errors=2)
TEST: test-clear-password.py
EE..
======================================================================
ERROR: testAsyncNotFound (__main__.TestRemove)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test-clear-password.py", line 68, in testAsyncNotFound
loop = GLib.MainLoop(None, False)
TypeError: function takes at most 0 arguments (2 given)
======================================================================
ERROR: testAsynchronous (__main__.TestRemove)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test-clear-password.py", line 55, in testAsynchronous
loop = GLib.MainLoop(None, False)
TypeError: function takes at most 0 arguments (2 given)
----------------------------------------------------------------------
Ran 4 tests in nans
FAILED (errors=2)
TEST: test-store-password.py
E.
======================================================================
ERROR: testAsynchronous (__main__.TestStore)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test-store-password.py", line 55, in testAsynchronous
loop = GLib.MainLoop(None, False)
TypeError: function takes at most 0 arguments (2 given)
----------------------------------------------------------------------
Ran 2 tests in nans
FAILED (errors=1)
TEST: test-unstable.py
----------------------------------------------------------------------
Ran 1 test in 0.403s
OK
TEST: test-lookup-password.js
JS ERROR: !!! Exception was: [object Object]
JS ERROR: !!! message = 'undefined'
JS ERROR: !!! fileName = 'undefined'
JS ERROR: !!! lineNumber = 'undefined'
JS ERROR: !!! stack = 'undefined'
[object Object]
TEST: test-clear-password.js
JS ERROR: !!! Exception was: [object Object]
JS ERROR: !!! message = 'undefined'
JS ERROR: !!! fileName = 'undefined'
JS ERROR: !!! lineNumber = 'undefined'
JS ERROR: !!! stack = 'undefined'
[object Object]
TEST: test-store-password.js
JS ERROR: !!! Exception was: [object Object]
JS ERROR: !!! message = 'undefined'
JS ERROR: !!! fileName = 'undefined'
JS ERROR: !!! lineNumber = 'undefined'
JS ERROR: !!! stack = 'undefined'
[object Object]
TEST: test-unstable.js
TEST: test-vala-lang... (pid=26055)
/vala/lookup/sync: FAIL
GTester: last random seed: R02S184c12c48a3979425da0f21c479964f7
make[4]: *** [test-vala] Terminated
make[4]: Target `check-local' not remade because of errors.
Many, many of the tests passed at the beginning of the run.
>> <application>GeoClue's</application> private executables into
>> <filename class="libraryfile">/usr/lib/geoclue</filename>.
>> </para>
>>
>
> I've always wanted to ask for this one.
>
> Can't we just stop explaining --whateverdir=/path/to/whatever switches?
> I mean, it should be obvious that it is setting installation paths for,
> lets say, docs, executable, whatever.
I agree But if they are already in the book, what is the harm in keeping them?
Hopefully, I responded to all your comments. But because you did not trim any
of the original post, it makes it really hard to follow. I trimmed it up so
that we can read it better.
--
Randy
--
http://linuxfromscratch.org/mailman/listinfo/blfs-book
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
