Bruce Dubbs wrote these words on 03/20/06 08:33 CST: > Kristian Gavran wrote: >>I've found a small bug in BLFS svn book regarding >>MPlayer-1.0pre7try2. >> >>1. The configure command used in the BLFS book isn't completly right. We >>are using "/usr" as prefix so that the configure script can't locate the >>proprietary codecs which are installed in "/usr/lib/mplayer" in the step >>before.
That is why it says "If you installed any CODECs, ensure you add --with-codecsdir=/usr/lib/mplayer/codecs to the configure script." immediately following the installation of the CODECs. :-) I'm sure you just overlooked it. >>2. The configure script insists to configure the CFLAG for itself. So it >>would be usefull to bypass the CFLAG environment variable when calling >>the configure script. Further we should use a sed command to correct the >>autogenerated CFLAG. The reason for this is that the configure script >>generates an "-O4" switch in the config.mak. This is useless because the >>highest optimization flag supported by GCC is "-O3". The sed sounds like a good idea. As far as CFLAG goes, if the developer put it there, we usually keep it, as we feel the developer knows best what makes his program run best. Perhaps a note saying the MPlayer sets a default CFLAG so that folks know it and can remove it if they wish. >>3. Further we should use the configure switch "--disable-ossaudio" >>because OSS is deprecated AFAIK. It may be deprecated, but who are we to tell people what to use and what not to use? I could go either way with this, but it seems that if someone wants to disable OSS, they can do it on their own. We expect folks to examine the ./configure --help output. These last two items are good observations, but I'm not sure that we want to impose either on builders. We'll see what others say about it. >>I would suggest to use this command for configuring and intstalling >>mplayer: >> >>patch -Np1 -i ../MPlayer-1.0pre7try2-kernel_2.6-1.patch && >>patch -Np1 -i ../MPlayer-1.0pre7try2-gcc4-1.patch && >>patch -Np1 -i ../MPlayer-1.0pre7try2-jack_fixes-1.patch && >>patch -Np1 -i ../MPlayer-1.0pre7try2-x264_fixes-1.patch && >>CFLAGS= ./configure --prefix=/usr --confdir=/etc/mplayer >>--with-codecsdir=/usr/lib/mplayer/codecs \ >> --enable-largefiles --disable-ossaudio && >>sed -i "[EMAIL PROTECTED]@-O3@" config.mak && >>make My feeling is that only the sed is something we should consider doing. We can't expect folks to install the CODECS, so we can't default to putting the configure switch in. We make the suggestion that there are codecs they can install, and how to make MPlayer use them. That seems to be enough. Others may feel differently. Though others may feel differently, I'm against the CFLAGS and --disable-ossaudio ideas. -- Randy rmlscsi: [GNU ld version 2.15.94.0.2 20041220] [gcc (GCC) 3.4.3] [GNU C Library stable release version 2.3.4] [Linux 2.6.10 i686] 09:06:00 up 2 days, 15:42, 3 users, load average: 0.99, 0.69, 0.32 -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
