On Wed, Dec 7, 2022 at 5:39 AM Manuel Rego Casasnovas <r...@igalia.com> wrote:
> > On 07/12/2022 12:37, Yoav Weiss wrote: > > LGTM1 > > > > Thanks for working on this!! Looking at wpt.fyi, other implementations > > are passing the test suite for this to varying degrees. Does this intent > > cover full compliance with the test suite? (e.g. `type()`, `url()`, non > > `x` descriptors, and maybe other dimensions) Or does it only cover the > > unprefixing and further interop improvements will come later? > > I do wonder what's the goal of removing the prefix, if we're not also > improving the spec compliance and interoperability? > > If we ship "image-set" people would expect it's a complete feature, and > then they'll get confused when somethings don't work. How are we going > to explain which is shipping exactly, is there any kind of documentation > about that? > IMO, un-prefixing is an un-alloyed good thing, regardless of how spec compliant chromium's implementation is. If it is in fact as buggy as you suggest, then let the bugs flow! > > Cheers, > Rego > > > > > On Tuesday, December 6, 2022 at 3:23:32 AM UTC+1 Traian Captan wrote: > > > > > > Contact emails > > > > tcap...@chromium.org <mailto:tcap...@chromium.org> > > > > > > Explainer > > > > None > > > > > > Specification > > > > https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation > > <https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation > > > > > > > > Summary > > > > Unprefix -webkit-image-set to expose the current image-set > > functionality without needing the '-webkit-' prefix. > > > > > > > > Blink component > > > > Blink > > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink> > > > > > > > > Motivation > > > > Currently Blink only supports '-webkit-' prefixed image-set, while > > Gecko and WebKit support both prefixed and unprefixed versions. With > > this change interop with Gecko and WebKit will be increased by > > allowing web developers to use the current Blink image-set > > functionality both with and without the '-webkit-' prefix. > > > > > > Search tags > > > > image-set <https://chromestatus.com/features#tags:image-set> > > > > > > TAG review > > > > Skipping because this is a straightforward interop fix. > > > > > > TAG review status > > > > Not applicable > > > > > > Risks > > > > > > > > Interoperability and Compatibility > > > > The Interoperability Risk is Low. This change increases interop with > > Gecko and WebKit which already support both '-webkit-' prefixed and > > unprefixed image-set. The Compatibility Risk is Low. If both > > prefixed and standard versions are defined in the right order, and > > the standard version fails parsing, Blink will fallback to the > > prefixed version. The 'image-set-fallback' test has been added to > > verify this behavior. > > > > > > > > /Gecko/: Shipped/Shipping > > (https://hg.mozilla.org/integration/autoland/rev/5c09b1d070e2 > > <https://hg.mozilla.org/integration/autoland/rev/5c09b1d070e2>) > > > > /WebKit/: Shipped/Shipping > > (https://trac.webkit.org/changeset/202765/webkit > > <https://trac.webkit.org/changeset/202765/webkit>) > > > > /Web developers/: Strongly positive - This issue has been Starred by > > 55 users. > > > > /Other signals/: > > > > > > WebView application risks > > > > Does this intent deprecate or change behavior of existing APIs, such > > that it has potentially high risk for Android WebView-based > > applications? > > > > No > > > > > > > > Debuggability > > > > N/A > > > > > > Will this feature be supported on all six Blink platforms > > (Windows, Mac, Linux, Chrome OS, Android, and Android > WebView)? > > > > Yes > > > > > > Is this feature fully tested by web-platform-tests > > < > https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md > >? > > > > Yes > > https://wpt.fyi/results/css/css-images/image-set > > <https://wpt.fyi/results/css/css-images/image-set> > > > > > > Flag name > > > > CSSImageSet > > > > > > Requires code in //chrome? > > > > False > > > > > > Tracking bug > > > > https://crbug.com/630597 <https://crbug.com/630597> > > > > > > Estimated milestones > > > > 110 Or 111 > > > > > > > > Anticipated spec changes > > > > Open questions about a feature may be a source of future web compat > > or interop issues. Please list open issues (e.g. links to known > > github issues in the project for the feature specification) whose > > resolution may introduce web compat/interop risk (e.g., changing to > > naming or structure of the API in a non-backward-compatible way). > > > > None > > > > > > Link to entry on the Chrome Platform Status > > > > https://chromestatus.com/feature/5109745420075008 > > <https://chromestatus.com/feature/5109745420075008> > > > > This intent message was generated by Chrome Platform Status > > <https://chromestatus.com/>. > > > > -- > > You received this message because you are subscribed to the Google > > Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to blink-dev+unsubscr...@chromium.org > > <mailto:blink-dev+unsubscr...@chromium.org>. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5e1384ee-25d0-4e9c-aab4-599faaf02e59n%40chromium.org > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5e1384ee-25d0-4e9c-aab4-599faaf02e59n%40chromium.org?utm_medium=email&utm_source=footer > >. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/250ec61a-ba76-3bb3-8798-c1e546d7a554%40igalia.com > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHOQ7J8FkuLNH%2BpFYYJG0%3DJrqDj9YANwYSGC2FDjmaRmAT1%2BVA%40mail.gmail.com.
