If we have plans to fix issues on this feature later, why not fixing them before and then shipping when things look good?
If we unprefix it, it'll kind of appear as a new Chromium feature that people can use, and they will expect it follows the spec. But we'll have to document it just works for this specific syntax but not this other and things like that, which would be hard to document and explain. Then as bugs are fixed more syntax will be supported, how are we going to announce that? Checking the tests results in wpt.fyi: https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=master&product=chrome%5Bexperimental%5D&product=chrome%5Bstable%5D&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&aligned&view=subtest I'm confused about the first examples there: * e.style['background-image'] = "image-set(url(example.png) 1x)" is passing But: * e.style['background-image'] = "-webkit-image-set(url(example.png) 1x)" should set the property value is not passing The first test is failing in without the runtime flag, and is passing with it. I'm not sure I'm understanding what we're shipping exactly, as I understood it was the same syntax than then prefixed version. Cheers, Rego On 08/12/2022 03:47, Traian Captan wrote: > Hi Rego, > > > I do wonder what's the goal of removing the prefix, if we're not also > improving the spec compliance and interoperability? > > It's an incremental step in the direction of spec compliance and > interoperability. > Further improvements will follow. > This is similar to how Firefox handled the implementation, splitting it > over several patches and releases > (https://bugzilla.mozilla.org/show_bug.cgi?id=1107646 > <https://bugzilla.mozilla.org/show_bug.cgi?id=1107646>). > > If we ship "image-set" people would expect it's a complete feature, and > then they'll get confused when somethings don't work. How are we going > to explain which is shipping exactly, is there any kind of documentation > about that? > > I would expect that if they find something that doesn't work, they would > open bug / feature requests, which we can use to prioritize what we > should look at implementing next. > > Regards, > Traian > > -- > You received this message because you are subscribed to the Google > Groups "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to blink-dev+unsubscr...@chromium.org > <mailto:blink-dev+unsubscr...@chromium.org>. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFxahvsO-axM0xi_E1bKQHk0_KgorSsJCQKmdA4EM_axOgm5hg%40mail.gmail.com > > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFxahvsO-axM0xi_E1bKQHk0_KgorSsJCQKmdA4EM_axOgm5hg%40mail.gmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cf00b332-6a63-9dd4-ed85-a91f8a0f2089%40igalia.com.
