On Fri, Mar 15, 2024 at 4:11 PM Raphael Kubo da Costa < raphael.kubo.da.co...@intel.com> wrote:
> Philip Jägenstedt <foo...@chromium.org> writes: > > > Taking a look at https://wpt.fyi/results/compute-pressure I see that > most > > of the tests are tentative. Should they still be, or why doesn't the spec > > cover so much of the behavior? > > As someone who reviewed most of the test: I think "tentative" should be > removed from the file names. The original web tests from years ago [1] > were tentative, so we ended up keeping it for all tests that were added > later as an oversight. > > [1] > https://github.com/web-platform-tests/wpt/commit/5bf9aca03e4c10345c0d023d1864ac9c6c7957e1 > > With that said, I think the current coverage is quite good (and what we > can't test in WPT is being tested in services_unittests), was there > anything that indicated that coverage was not ideal or is it because of > the presence of "tentative" in the test names? I just wondered why so many tests are tentative. It easily happens that tests are left tentative longer than needed, and it sounds like that's the case here. Taking a closer look, I think it's really because the tests depend on MojoJS, and if we exclude tentative tests <https://wpt.fyi/results/compute-pressure?label=master&label=experimental&aligned&q=%21is%3Atentative> only surface level tests remain. Compute Pressure tests were mentioned in https://github.com/web-platform-tests/rfcs/issues/172 and my read is that Apple and Mozilla would prefer that we not upstream tests that depend on unspecified testing APIs. I'd suggest one of the following: - Define a WebDriver Classic endpoint in the style of https://w3c.github.io/sensors/#automation - Define a WebDriver BiDi command in the style of https://w3c.github.io/permissions/#automation-webdriver-bidi - Define a testing API in the style of https://wicg.github.io/webusb/test/ - Move the tests to wpt_internal (meaning much fewer shared tests for a second implementer) What do you think makes the most sense here? -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYe0kLQStd4XnZ_TgoToZgjkVLpm%3DT_LrVO5ga0nmgR9aQ%40mail.gmail.com.
