On Thu, Oct 16, 2025 at 03:24:59PM +0200, Jiri Pirko wrote: > Thu, Oct 16, 2025 at 02:38:15PM +0200, [email protected] wrote: > >On Thu, Oct 16, 2025 at 01:27:00PM +0200, Jiri Pirko wrote: > >> >> How about "master_upper"? This is already widely used to refer to > >> >> bond/team/bridge/other master soft devices. > >> >> > >> >> MASTER_UPPER_DEV_VLAN_FEATURES? > >> > > >> >I'm not sure if we should avoid using "master" now. Maybe just > >> >UPPER_DEV_VLAN_FEATURES? > >> > >> Why? We have "master_upper" to point exactly at this kind of device. > > > >I mean try not use "master/slave" words. I'm OK to use UPPER_DEV_* prefix. > > If you don't want to use that, change the existing code. But when the > existing code uses that, new code should be consistent with it.
OK, I will update the name. Thanks Hangbin
