On Mon, 2 Mar 2026 11:51:52 GMT, Kurt Miller <[email protected]> wrote:
>> This basically allows configure to complete and set up a configuration >> suitable for building the BSD port for supported platforms (FreeBSD, OpenBSD >> and NetBSD.) >> >> The flag `_BSDONLY_SOURCE` is defined for all the BSD's _except_ for Apple >> MacOS, while the existing `_ALLBSD_SOURCE` _includes_ Apple MacOS. >> >> For the BSD's we set the `OPENJDK_TARGET_OS_ENV` variable to distinct values >> reflecting the BSD variant being built. This is used to distinguish build >> flags, library locations and what libraries and modules to include for the >> various builds. >> >> As an example, FreeBSD includes the ALSA library, and should build the >> Serviceability Agent, while the other BSD's do not. >> >> This work was sponsored by: The FreeBSD Foundation > > @snake66 There may be more setup to do on this branch as well. I don’t see > the bot automatically adding the labels to the PR. For example this one > probably should be labeled `build` by the bot. > > It also looks like we could self review PRs to bsd-port (meaning you, me and > Greg), but I thought the goal here was to have OpenJDK developers review each > PR to this branch so that at the end of this process when bsd-port branch > matches the dev branch and is ready to be proposed for merging to mainline, > the whole of bsd-port would have been reviewed in PR sized chunks. If this is > accurate, then we may need some guidance and help from OpenJDK devs on how to > be setup correctly so GitHub enforces this process on the bsd-port branch. @bsdkurt > One of the things I would like to see is the results of the GitHub actions > builds and tests to ensure any PRs pushed to the bsd-port branch here don’t > break them. Yes, I would like that too, but for now we're quite far from that to be very useful for this branch. We could add a workflow that only runs configure for now, I guess. And expand that as more pieces fall into place. I can look into that, but probably as a separate PR. Making the PR's originate from my personal fork (or battleblow/jdk) is probably a good idea in any case though. > There may be more setup to do on this branch as well. I don’t see the bot > automatically adding the labels to the PR. It added the `rfr` label, but I was also hoping it would add the `build` label. For now I just forwarded the RFR email from the bsd-port list to the build list manually. Not sure if the bot is supposed to add the other labels automatically, or if we'll have to get people on board for reviews manually. I suspect the latter. > It also looks like we could self review PRs to bsd-port Afact, I am not a committer, so don't think I can accept the PR. Maybe you and Greg can, but yes, that would defeat the purpose. We do need registered (outside) committers to accept the PRs. The reason I added you and Greg was so that you can oppose it. It's good that we all agree to the PR. While hoping this PR will be accepted so we can land it, I explicitly chose a minimal and easy one to test and figure out the workflow. ------------- PR Comment: https://git.openjdk.org/bsd-port/pull/3#issuecomment-3984410097
