On Sat, 28 Feb 2026 11:49:54 GMT, Harald Eilertsen <[email protected]> wrote:
> This basically allows configure to complete and set up a configuration > suitable for building the BSD port for supported platforms (FreeBSD, OpenBSD > and NetBSD.) > > The flag `_BSDONLY_SOURCE` is defined for all the BSD's _except_ for Apple > MacOS, while the existing `_ALLBSD_SOURCE` _includes_ Apple MacOS. > > For the BSD's we set the `OPENJDK_TARGET_OS_ENV` variable to distinct values > reflecting the BSD variant being built. This is used to distinguish build > flags, library locations and what libraries and modules to include for the > various builds. > > As an example, FreeBSD includes the ALSA library, and should build the > Serviceability Agent, while the other BSD's do not. > > This work was sponsored by: The FreeBSD Foundation Hi! I'm Julian from the build group and a Committer for the mainline JDK. I'm not a Reviewer yet nor do I have a registered role within the BSD port, but I could page for the main build developers, if you'd like, or help directly with anything build system related and move the process forward slowly while we wait for more experienced Reviewers from the build team to arrive. > @snake66 There may be more setup to do on this branch as well. I don’t see > the bot automatically adding the labels to the PR. For example this one > probably should be labeled `build` by the bot. > It added the `rfr` label, but I was also hoping it would add the `build` > label. For now I just forwarded the RFR email from the bsd-port list to the > build list manually. Not sure if the bot is supposed to add the other labels > automatically, or if we'll have to get people on board for reviews manually. > I suspect the latter. I believe Skara is configured to set the labels for the appropriate parts of the JDK being worked on only in the mainline JDK, so other JDK repositories like this one won't have that ability to have the appropriate label set based on which parts of the code were touched. You may have to ask Erik for confirmation on that though. It's rather late for me at the moment though, so anything more than a quick cursory glance of the code may have to wait until tomorrow, if that's fine with you. But ignoring that, what can I do for you (Besides reviewing the code)? ------------- PR Comment: https://git.openjdk.org/bsd-port/pull/3#issuecomment-3984619285
