On Sat, 28 Feb 2026 11:49:54 GMT, Harald Eilertsen <[email protected]> wrote:

> This basically allows configure to complete and set up a configuration 
> suitable for building the BSD port for supported platforms (FreeBSD, OpenBSD 
> and NetBSD.)
> 
> The flag `_BSDONLY_SOURCE` is defined for all the BSD's _except_ for Apple 
> MacOS, while the existing `_ALLBSD_SOURCE` _includes_ Apple MacOS.
> 
> For the BSD's we set the `OPENJDK_TARGET_OS_ENV` variable to distinct values 
> reflecting the BSD variant being built. This is used to distinguish build 
> flags, library locations and what libraries and modules to include for the 
> various builds.
> 
> As an example, FreeBSD includes the ALSA library, and should build the 
> Serviceability Agent, while the other BSD's do not.
> 
> This work was sponsored by: The FreeBSD Foundation

Looks ok. Using the OS_ENV for BSD flavor is interesting, but it's a free 
dimension outside of windows so should be fine I think. Some lines ended up a 
bit long, and we try to break those up for easier side by side diffs and 3 way 
merges in the future.

-------------

PR Review: https://git.openjdk.org/bsd-port/pull/3#pullrequestreview-3876478310

Reply via email to