Hello! Marius Bakke <mba...@fastmail.com> skribis:
> Ricardo Wurmus <rek...@elephly.net> writes: > >> Marius Bakke <mba...@fastmail.com> writes: >> >>> Gábor Boskovits <boskov...@gmail.com> writes: >>> >>>> It seems, that we have a breakage in current core-updates. m4, gettext, and >>>> at least a few other packages fail to build. >>> >>> Hello! >>> >>> The problem is that the glibc version string is used a couple of places >>> to determine where locales are found. >>> >>> The attached patch fixes it, though I'm not sure if it's the best >>> approach. Thoughts? >> >> Thank you. >> >> I find it a little ugly to replace the exact version string with only >> the major+minor version substring. Why can’t we use the full version >> string? > > I think it's because "glibc-versioned-locpath.patch" uses the libc > VERSION constant. Right. That’s akin to the “effective version” string as defined in Guile and other packages for cases where you only care about MAJOR.MINOR. > Perhaps we could substitute glibcs "version.h", but that might break > other things. Or introduce a different variable, say > GUIX_GLIBC_VERSION, and use that. WDYT? FWIW I think your patches does the right thing. If we want to reduce ugliness, we can always add an ‘effective-glibc-version’ property in the glibc package, but that probably won’t be much less ugly than calling ‘version-major+minor’. Thoughts? Ludo’.