On Friday, November 19, 2010 10:12:44 Simon Josefsson wrote: > Simon Josefsson <[email protected]> writes: > > Mike Frysinger <[email protected]> writes: > >> The C library itself defines a "ruserpass" function. When linking > >> statically, it is possible to hit a symbol collision linker error. > >> So rename the local ftp version to "remote_userpass". > > > > Applied and pushed. Next time, please include a patch for ChangeLog as > > well. > > Btw, would it make sense to _use_ the glibc ruserpass symbol instead of > providing our own implementation? The glibc implementation looks > similar to the one we have. On the other hand -- the function is not > documented in the glibc manual nor is it a POSIX function, so I'm not > sure how stable the glibc implementation should be considered to be.
i'm not actually using glibc, so i'd prefer we stick to standards rather than use even more undocumented features. -mike
signature.asc
Description: This is a digitally signed message part.
