Sebastian Huber commented on a discussion on bsps/powerpc/shared/start/sbrk.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1414#note_158266

 >      remaining_size  = rval;
 >    }
 >  
 > -  policy = (0 == BSP_sbrk_policy[0] ? (uintptr_t)(-1) : BSP_sbrk_policy[0]);
 > +  /*
 > +   * BSP_sbrk_policy is an optional application provided symbol. Test the
 > +   * symbol address before the dereference, otherwise an application which
 > +   * does not provide the symbol reads whatever resides at address zero.
 > +   */
 > +  if (BSP_sbrk_policy == NULL || 0 == BSP_sbrk_policy[0]) {

Yes, getting rid of Joda style is always good. I will adjust the patch.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1414#note_158266
You're receiving this email because of your account on gitlab.rtems.org. 
Unsubscribe from this thread: 
https://gitlab.rtems.org/-/sent_notifications/5-8mofs88u5bb3wr6v6mwfhhqwu-1d/unsubscribe
 | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | 
Help: https://gitlab.rtems.org/help


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to