----- Original Message ----- > I can't find the original jdk8 review thread either. > > Good catch Andrew. I've created a bug ID for you : (should be live in > next 1-2 days) > 7192804 : Build should not install jvisualvm man page for OpenJDK >
Thanks :-) > Needs addressing in JDK8 and 7u. JDK8 will need addressing in the old > and new makefile systems. > Ah good catch. I didn't realise this was duplicated in the new build system. http://cr.openjdk.java.net/~andrew/jvisualvm/webrev.02/ should deal with both cases. If this is ok, is there a preferred forest to push to? I've been testing against build, but can easily push it somewhere else. > regards, > Sean. > > On 20/08/2012 18:57, Andrew Hughes wrote: > > ----- Original Message ----- > >> This fix is also addressed in jdk8 at the same time. > >> > >> Bug: http://bugs.sun.com/view_bug.do?bug_id=7157855 > >> Webrev: http://cr.openjdk.java.net/~mfang/7157855/ > >> Reviewers: katleman, thurka > >> > >> thanks, > >> > >> -michael > >> > > Do you have a link to where this was reviewed? I don't see it in > > my inbox. > > > > There is a flaw in this patch. jvisualvm is not part of OpenJDK so > > the man > > page should not be installed if building OpenJDK. > > > > The same bug had to be rectified for javaws in 7021314: Build > > should not install javaws man page. > > > > I'll post a webrev but basically it needs to be surrounded by an > > #ifndef OPENJDK. > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07