If I understand correctly, this removes the directory containing
the JDK's copy of giflib sources from the set of locations to be
compiled etc, and replaces it with just a link line pointer to use
"libgif" which is then expected to be on the default linker path,
ie in /usr/lib.
I think this is fine except I would guard USE_EXTERNAL_LIBGIF
with an expectation that this is at least "not" windows, since
I'm pretty sure that option would always be a mistake there.
> 502 USE_EXTERNAL_LIBJPEG=true
This appears to have been a bug in the old autoconf.m4, yes ?
-phil.
PS I count as a JDK 8 reviewer ..
On 3/8/2013 3:12 AM, Erik Joelsson wrote:
On 2013-03-08 03:59, Omair Majid wrote:
Hi,
I have a webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/00/
It introduces a configure option --with-giflib that (similar to the
existing --with-zlib) allows specifying whether the build should use the
system installed giflib or the one bundled with OpenJDK.
I have not tested it extensively yet (just verified that it builds fine
with both configurations), but I will do that over the coming days if
the patch looks (somewhat) acceptable for OpenJDK8.
Looks good from the build group. (You still need a jdk8 reviewer to
approve too)
/Erik
