On 03/08/2013 12:26 PM, Phil Race wrote: > If I understand correctly, this removes the directory containing > the JDK's copy of giflib sources from the set of locations to be > compiled etc, and replaces it with just a link line pointer to use > "libgif" which is then expected to be on the default linker path, > ie in /usr/lib.
Yes, that was what I intended. The JDK's copy of giflib is still compiled if --with-giflib=system is used. > I think this is fine except I would guard USE_EXTERNAL_LIBGIF > with an expectation that this is at least "not" windows, since > I'm pretty sure that option would always be a mistake there. I will post an updated patch soon with this fixed. >> 502 USE_EXTERNAL_LIBJPEG=true > > This appears to have been a bug in the old autoconf.m4, yes ? Yes, it's definitely a (harmless?) bug. The old file looks like this: 485 ################################################################## 486 # 487 # Check for the jpeg library 488 # 489 490 USE_EXTERNAL_LIBJPEG=true 491 AC_CHECK_LIB(jpeg, main, [], 492 [ USE_EXTERNAL_LIBJPEG=false 493 AC_MSG_NOTICE([ .. snipped ... ]) 494 ]) 495 AC_SUBST(USE_EXTERNAL_LIBJPEG) 496 497 ################################################################## 498 # 499 # Check for the gif library 500 # 501 502 USE_EXTERNAL_LIBJPEG=true 503 AC_CHECK_LIB(gif, main, [], 504 [ USE_EXTERNAL_LIBGIF=false 505 AC_MSG_NOTICE([ .. snipped ...]) 506 ]) 507 AC_SUBST(USE_EXTERNAL_LIBGIF) So ${USE_EXTERNAL_LIBJPEG} is "true" and ${USE_EXTERNAL_LIBGIF} is either "" or "false". Neither of these are used in CompileNativeLibraries.gmk, however. > PS I count as a JDK 8 reviewer .. Thanks for the review. Could I get a bug id, please? Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681