Hi, Updated webrev at: http://cr.openjdk.java.net/~omajid/webrevs/system-giflib/01/
The webrev borrows some idioms that Andrew Hughes pointed out, and uses system headers for giflib too. I checked this by building --with-libgif=system and also by removing the src/share/native/sun/awt/giflib dir and using --with-giflib=system. On 03/08/2013 12:26 PM, Phil Race wrote: > If I understand correctly, this removes the directory containing > the JDK's copy of giflib sources from the set of locations to be > compiled etc, and replaces it with just a link line pointer to use > "libgif" which is then expected to be on the default linker path, > ie in /usr/lib. > > I think this is fine except I would guard USE_EXTERNAL_LIBGIF > with an expectation that this is at least "not" windows, since > I'm pretty sure that option would always be a mistake there. The updated webrev does that. I don't have a windows machine to test this on, unfortunately. Any comments or suggestions? Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
