Hi Erik, Thanks for your comments. Sorry I couldn't get back to you earlier, I was busy with a conference.
Here's an updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/ On 06/05/2013 05:21 AM, Erik Joelsson wrote: > Is it required to remove the font/layout dir to use the system version? > I would expect USE_EXTERNAL_ICU_LE=true would add an exclude for that > directory to SetupNativeCompilation,BUILD_LIBFONTMANAGER. > > If you expect to delete the source tree on your side, why not have > configure check for the existence of the font/layout directory to > determine the default behavior for system vs bundled? That's a good point. The font/layout directory is only problematic because the build attempts to look up headers there instead of the system include paths first. Since it's desirable to make sure that the header files used are compatible with the icu library, removing the font/layout directory on build is one option. I have now worked around it by using different #includes for system/bundled cases. Everything should work correctly without needing to remove any files/directories. > It seems you forgot to add USE_EXTERNAL_ICU_LE to spec.gmk.in. You are right, of course. Fixed. > Are ICU_LE_CFLAGS and ICE_LE_LIBS supposed to be empty? Yes, they are empty on bundled builds. On system builds, they may not be. On my machine, with --with-icu-le=system, I get: ICU_LE_CFLAGS:= ICU_LE_LIBS:=-licule -licuuc -licudata > On 2013-06-04 23:30, Omair Majid wrote: >> FYI: I am quite sure the build breaks if built using the old build >> system; I will fix that next. This is still on my TODO list. Thanks, Omair
