Hi Phil, Updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/
It's still against jdk8/build and missing support for the old build system. On 06/05/2013 02:02 PM, Phil Race wrote: > Since this entirely affects a 2D component, please include 2d-dev in > this discussion. > I would have been 'surprised' to see this change if I hadn't just > spotted this thread. Mea culpa. I pushed a few similar system-library patches using this identical process and no one corrected me. So I assumed this was right. For the future, I will ensure the relevant groups are CC'd. > And I believe this change should be integrated via the 2D forest. Okay. Are there any guidelines for this? It's not obvious to me when a change is more appropriate for build vs 2D. > I am not sure what, if any, runtime problems might occur from using a > different > version. We've generally been able to swap in newer versions of ICU without > much trouble, but I recommend to run appropriate tests before shipping .. Thanks for the suggestions. Do you have any particular tests in mind? For some background, the goal with this change is two fold: 1. Gain benefits from system-installed libraries. This is one library where OpenJDK does not lag behind in security updates, but in some other cases, embedded libraries can lag behind. It also makes it easier to use the distributions preferred policies (hardening flags on libraries and so on). 2. Make it easier to switch to HarfBuzz at some later point. ICU itself strongly recommends switching [1]. Through ice-le-hb [2], only a recompile should be needed to switch (hopefully). > Note that JDK8 in fact has a very "current" ICU with some security fixes. > So I would not recommend using the native lib on a system with an older > ICU. Thanks for pointing it out. I see that ICU recently released a security update [1] too, but probably many distributions will not have this up-to-date version (my current distro, a little out-of-date, does not :( ). Thanks, Omair [1] http://site.icu-project.org/download/51 [2] https://github.com/behdad/icu-le-hb -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
