Hi Chris, I had a look at the changes in java.logging and java.management modules (+ corresponding tests) and they look reasonable to me.
I also had a cursory look at the jdeps changes. It's difficult for me to review that without importing the changes and playing with the tool as this is a part I'm less familiar with - but I didn't see anything that would be obviously wrong. I skipped most of the rest (especially the build changes ;-)). best regards, -- daniel On 20/11/14 22:41, Chris Hegarty wrote:
From: Chris Hegarty <chris.hega...@oracle.com> Subject: RFR [JEP 220] Modular Run-Time Images Date: 20 November 2014 21:39:14 GMT To: jigsaw-dev <jigsaw-...@openjdk.java.net>, jdk9-dev <jdk9-...@openjdk.java.net>, build-dev <build-dev@openjdk.java.net>, Alan Bateman <alan.bate...@oracle.com>, Alex Buckley <alex.buck...@oracle.com>, Chris Hegarty <chris.hega...@oracle.com>, Erik Joelsson <erik.joels...@oracle.com>, Jonathan Gibbons <jonathan.gibb...@oracle.com>, Karen Kinnear <karen.kinn...@oracle.com>, "Jim Laskey (Oracle)" <james.las...@oracle.com>, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>, Mandy Chung <mandy.ch...@oracle.com>, Mark Reinhold <mark.reinh...@oracle.com>, Paul Sandoz <paul.san...@oracle.com>, "A. Sundararajan" <sundararajan.athijegannat...@oracle.com> This is a review request for the changes for JEP 220: Modular Run-Time Images [1]. There are a number of individuals responsible for these changes. Some, possibly not all, are explicitly listed in the 'To' section of this mail, and they will help address any comments arising from this review request. The new run-time image structure is defined in JEP 220 [1], and can be seen as a result of building the staging forest [2], or in the early access builds [3]. Webrevs: http://cr.openjdk.java.net/~chegar/8061971/00/ Due to the significant impact of these changes, a JDK 9 promotion has been tentatively reserved for their integration. All comments are welcome, although given the nature of the changes then we might have to create separate issues in JIRA to address some of them later in jdk9/dev. -Chris. [1] http://openjdk.java.net/jeps/220 [2] http://hg.openjdk.java.net/jigsaw/m2/ [3] http://openjdk.java.net/projects/jigsaw/ea
