Hi,

All patches to OpenJDK must be submitted on OpenJDK infrastructure. This means either hosted on cr.openjdk.java.net or else included inline, or as attachments, to emails to the OpenJDK mailing lists. Patches hosted on github are not acceptable.

Thanks,
David

On 27/12/2018 10:56 pm, Fu Jie wrote:
Hi all,


OpenJDK build with NetBeans failed during the pre-build process.
The reason is that configuration in make/nb_native/nbproject/configurations.xml is wrong.

The setting that leads to the failure is:
       <preBuildCommand>sh ../configure --with-debug-level=slowdebug --disable-zip-debug-info</preBuildCommand>

Two pionts were wrong here:
 1) the path of configure script specified was incorrect which should just be "sh configure" instead of "sh ../configure".  2) deprecated --disable-zip-debug-info was used which is now an unrecognized option.

The pre-build succeeded with the following configuration. For more info., see [1].        <preBuildCommand>sh configure --with-debug-level=slowdebug</preBuildCommand>


Further more, there are too many invalid items in make/nb_native/nbproject/configurations.xml. For example This item is invalid since advancedThresholdPolicy.cpp had been removed from the project. ----------------------------------------------------------------------------         <item path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp"
               ex="false"
               tool="1"
               flavor2="0">
         </item>
----------------------------------------------------------------------------
For more invalid items, see [2].


To fix the issues, make/nb_native/nbproject/configurations.xml needs to be updated. And I made a patch[3] for this.
Could anyone help to review it? Thank you!

[1] https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md [2] https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md [3] https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff

Best regards,
Fu Jie


Reply via email to