On 28/12/2018 06:34, Fu Jie wrote:
Hi,
Please review this patch for a build failure with NetBeans:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215952
Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/
Summary
The build failure is caused by an incorrect setting of preBuildCommand
in make/nb_native/nbproject/configurations.xml.
And all invalid source code items in configurations.xml have been
removed.
I don't know the complete history as to why these project files are
checked into the repo but doesn't it mean configuration.xml needs to be
updated every time that a .c, .h, .cpp, or .hpp file is added, moved, or
removed? I assume it will need to an update every week to keep it
current so I wonder if you've looked at checking in a script that
generates the project to avoid this ongoing maintenance.
-Alan
