On Fri, 20 Nov 2020 17:31:51 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Robin Westberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve naming, fix style issues > > Looks good! A few minor nits, if you want to address them. Ah wait, I now see "Linux additional" is the column name in testing table, because it is the name of the job! Eh... It was nicer to have columns per arch. Does it make sense to split the "Linux x64 (other)" and "Linux Foreign" then? It might also simplify the coding as we would not have to check for `matrix.debian_arch`. EDIT: Or maybe it is fine to have "Linux additional", as it stand now. Really undecided here :) ------------- PR: https://git.openjdk.java.net/jdk/pull/1350
