On Fri, 20 Nov 2020 17:35:12 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Looks good! A few minor nits, if you want to address them. > > Ah wait, I now see "Linux additional" is the column name in testing table, > because it is the name of the job! Eh... It was nicer to have columns per > arch. Does it make sense to split the "Linux x64 (other)" and "Linux Foreign" > then? It might also simplify the coding as we would not have to check for > `matrix.debian_arch`. > > EDIT: Or maybe it is fine to have "Linux additional", as it stand now. Really > undecided here :) I personally think I prefer to just use a single column for the additional cross compile builds, because the table becomes very big otherwise (and the rows get split up). You still see the full name of the build in case anything fails, so not sure it adds that much value to get an additional box for each cross-compiled architecture, I guess in 99% of cases they will just pass and then you don't really care exactly which platforms you didn't break.. But I'm no UX expert. :) ------------- PR: https://git.openjdk.java.net/jdk/pull/1350
