> Several parts of the make system in the JDK has large parts of cluttered if > branches dedicated to setting flags for the specific compiler used in the > build. This could be more neatly accomplished by instead adding more target > combinations in SetupNativeCompilation so the callsite can more cleanly > specify which OS and compiler it desires to set these flags for. The change > currently includes: > > DISABLED_WARNINGS (including per file warnings), CFLAGS/CXXFLAGS and LDFLAGS: > Compiler-then-OS (The priority shown reflects how the flags depend more so on > the compiler) > LIBS: OS-then-Compiler, as libraries typically vary based on the system being > compiled for
Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Extra spacing ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10634/files - new: https://git.openjdk.org/jdk/pull/10634/files/0244a6e1..9c394a77 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10634&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10634&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10634.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10634/head:pull/10634 PR: https://git.openjdk.org/jdk/pull/10634
