On Mon, 10 Oct 2022 15:08:43 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> Several parts of the make system in the JDK has large parts of cluttered if > branches dedicated to setting flags for the specific compiler used in the > build. This could be more neatly accomplished by instead adding more target > combinations in SetupNativeCompilation so the callsite can more cleanly > specify which OS and compiler it desires to set these flags for. The change > currently includes: > > DISABLED_WARNINGS (including per file warnings), CFLAGS/CXXFLAGS and LDFLAGS: > Compiler-then-OS (The priority shown reflects how the flags depend more so on > the compiler) > LIBS: OS-then-Compiler, as libraries typically vary based on the system being > compiled for This pull request has now been integrated. Changeset: 9adb7283 Author: Julian Waters <jwat...@openjdk.org> Committer: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/9adb72837836c5cd67cd41af36aac3c07274f01b Stats: 48 lines in 1 file changed: 37 ins; 0 del; 11 mod 8295070: Introduce more target combinations for compiler flags Reviewed-by: erikj, ihse ------------- PR: https://git.openjdk.org/jdk/pull/10634
