On Mon, 10 Oct 2022 15:29:16 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Several parts of the make system in the JDK has large parts of cluttered if >> branches dedicated to setting flags for the specific compiler used in the >> build. This could be more neatly accomplished by instead adding more target >> combinations in SetupNativeCompilation so the callsite can more cleanly >> specify which OS and compiler it desires to set these flags for. The change >> currently includes: >> >> DISABLED_WARNINGS (including per file warnings), CFLAGS/CXXFLAGS and >> LDFLAGS: Compiler-then-OS (The priority shown reflects how the flags depend >> more so on the compiler) >> LIBS: OS-then-Compiler, as libraries typically vary based on the system >> being compiled for > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Extra spacing Okay, go ahead. ------------- Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.org/jdk/pull/10634
