On Tue, 6 Dec 2022 14:07:59 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available
>> when both 8282948 and 8282700 were written. They can now be moved to using
>> the cleaner logic that UTIL_ARG_WITH grants.
>>
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4.
>> They are out of the scope of this commit, which aims only to rework the
>> previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> CHECK_VALUE
make/autoconf/jdk-version.m4 line 525:
> 523: DEFAULT: $MACOSX_BUNDLE_NAME_BASE,
> 524: DESC: [Set the MacOSX Bundle Name base. This is the base name for
> calculating MacOSX Bundle Names.],
> 525: DEFAULT_DESC: [not specified],
Suggestion:
DEFAULT_DESC: [from branding.conf],
make/autoconf/jdk-version.m4 line 545:
> 543: DEFAULT: $MACOSX_BUNDLE_ID_BASE,
> 544: DESC: [Set the MacOSX Bundle ID base. This is the base ID for
> calculating MacOSX Bundle IDs.],
> 545: DEFAULT_DESC: [not specified],
Suggestion:
DEFAULT_DESC: [based on branding.conf and VERSION_PRE],
make/autoconf/jdk-version.m4 line 571:
> 569: DESC: [Set the MacOSX Bundle CFBundleVersion field. This key is a
> machine-readable
> 570: string composed of one to three period-separated integers and
> should represent the
> 571: build version. Defaults to the build number.],
Please remove the text about the default from DESC, and add:
DEFAULT_DESC: [the build number],
-------------
PR: https://git.openjdk.org/jdk/pull/11020
