On Tue, 6 Dec 2022 14:07:59 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available
>> when both 8282948 and 8282700 were written. They can now be moved to using
>> the cleaner logic that UTIL_ARG_WITH grants.
>>
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4.
>> They are out of the scope of this commit, which aims only to rework the
>> previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> CHECK_VALUE
make/autoconf/jdk-version.m4 line 78:
> 76: UTIL_ARG_WITH(NAME: build-user, TYPE: string,
> 77: RESULT: USERNAME,
> 78: DEFAULT: [ `$ECHO "$USER" | $TR -d -c '[a-z][A-Z][0-9]'` ],
Can you move this outside the UTIL_ARG_WITH block and assign it to a variable?
I'm worried this might be evaluated multiple times otherwise.
Also, I know this was not present before, but please add something along the
lines of:
`DEFAULT_DESC: [current username, sanitized]`
make/autoconf/jdk-version.m4 line 93:
> 91: DESC: [Set JDK RC name. This is used for FileDescription and
> ProductName
> 92: properties of MS Windows binaries.],
> 93: DEFAULT_DESC: [not specified],
Suggestion:
DEFAULT_DESC: [from branding.conf],
make/autoconf/jdk-version.m4 line 111:
> 109: DESC: [Set vendor name. Among others, used to set the 'java.vendor'
> 110: and 'java.vm.vendor' system properties.],
> 111: DEFAULT_DESC: [not specified],
Suggestion:
DEFAULT_DESC: [from branding.conf],
make/autoconf/jdk-version.m4 line 127:
> 125: DEFAULT: $VENDOR_URL,
> 126: DESC: [Set the 'java.vendor.url' system property],
> 127: DEFAULT_DESC: [not specified],
Suggestion:
DEFAULT_DESC: [from branding.conf],
make/autoconf/jdk-version.m4 line 144:
> 142: DEFAULT: $VENDOR_URL_BUG,
> 143: DESC: [Set the 'java.vendor.url.bug' system property],
> 144: DEFAULT_DESC: [not specified],
Suggestion:
DEFAULT_DESC: [from branding.conf],
-------------
PR: https://git.openjdk.org/jdk/pull/11020
