On Tue, 6 Dec 2022 13:09:41 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> make/conf/branding.conf line 27: >> >>> 25: >>> 26: LAUNCHER_NAME=openjdk >>> 27: PRODUCT_NAME=OpenJDK >> >> This mix of `NNNN` and `DEFAULT_NNNN` looks a bit strange. Is it so that the >> one's that are not prefixed with `DEFAULT_` cannot be overridden by >> configure flags? > > It's more just me trying to preserve the original names, I don't really want > to change too many things here. I'll change them to DEFAULT_ instead if you > prefer that though. I don't feel like this is my decision to make > > Sorry for taking so long to reply, half the keys don't work on this > disintegrating piece of junk (such as the letter "t"), I've had to Ctrl+C > Ctrl+V all the letters that are broken on this keyboard just to get coherent > messages out Hm. I'm beginning to regret my request to rename these variables. Let me go back to the code where this was used to see if there could be a better way to solve this. ------------- PR: https://git.openjdk.org/jdk/pull/11020
