On Thu, 8 Dec 2022 16:12:29 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove Yoda notation
>
> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 209:
> 
>> 207:                         .filter(c -> '.' == c)
>> 208:                         .mapToObj(c -> "../")
>> 209:                         .collect(joining());
> 
> What about nested classes?
> 
> You might want to derive `backNavigator` and `forwardNavigator` from the 
> _package_ of the `TypeElement`.  Look at `Elements.getPackageOf(Element)`.

I think nested classes are ok (e.g. `a.b.c.Main$Foo` would work).

-------------

PR: https://git.openjdk.org/jdk/pull/11580

Reply via email to