On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\afscript.h(1): > warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを > Unicode 形式で保存してください。 > > > I added C4819 to DISABLED_WARNINGS_microsoft for libfontmanager and for > libfreetype because they are 3rd-party libraries. Fix rejected for the same reasons as described in https://github.com/openjdk/jdk/pull/12437 " declare the source to be utf-8, " you can't do that if you don't own the code, can you ? Regardless this fix isn't right. ------------- PR: https://git.openjdk.org/jdk/pull/12436
