On Tue, 7 Feb 2023 00:01:56 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
> I grep'ed (with `-i`) in `doc` directory with `LANG`, `utf`, `locale`, but I > could not find out them. I guess locale of build environment is not mentioned > clearly. Is it correct? > > I agree with you to use English locale (e.g. `LANG=C`) is prefered, but I > guess may difficult when we use WSL because `LANG` is not propergate to > Windows environment. > > I confirmed that it is succeeded to build with `--with-extra-cflags=/utf-8 > --with-extra-cxxflags=/utf-8`, so I think it is better to add them to build > option for Windows by default, but I'm not sure it is correct because no > documents mention to the locale. What do you think? I don't know if it is documented but it has been discussed multiple times over the years. Which encodings are *supposed* to work would be a good thing to document, LANG=C isn't strictly "English" and LC_* vars over-ride it but "en_US-iso-8859-1" (eg) definitely should work, because that or some close equivalent (windows cp1252 or maybe 1250) are what we've considered as "must work" (SFAIK) If the build team want to make utf-8 the default encoding and it can be done without having to worry unduly about 3rd party code and what might be in the repo today then that would be a good thing I expect. But it is a bigger conversation than this PR ------------- PR: https://git.openjdk.org/jdk/pull/12436
