On Thu, 20 Apr 2023 16:23:26 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> Currrent GHA fails on MSVC installation. Looks like the required versions >> are already installed in the runner image, and this is why the command >> fails. Our configure scripts look for the specific minor version, and the >> builds still pass if I drop the VC installation block completely. This tells >> me the appropriate minor version is already installed. >> >> For safety, I think we can just ignore the errors from the MSVC >> installation. In case the runner images moves on to another minor version >> later, the dependencies would start to install successfully again. >> >> See the GHA run. Both Windows x86_64 and Windows AArch64 select `1429~1.301`: >> >> >> * Toolchain: microsoft (Microsoft Visual Studio 2019) >> * C Compiler: Version 19.29.30148 (at >> /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe) >> * C++ Compiler: Version 19.29.30148 (at >> /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe) >> >> >> The last successful GHA run I had selected the same versions: >> >> >> Tools summary: >> * Toolchain: microsoft (Microsoft Visual Studio 2019) >> * C Compiler: Version 19.29.30148 (at >> /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe) >> * C++ Compiler: Version 19.29.30148 (at >> /c/progra~2/micros~2/2019/enterp~1/vc/tools/msvc/1429~1.301/bin/hostx64/x64/cl.exe) >> >> >> Additional testing: >> - [x] Ad-hoc GHA runs pass the configure/initial-build >> - [x] Full GHA runs pass (this PR) > > Looks good. Too bad that the Windows installer is not showing any sensible > output. > We will want to backport this to 11u and 17u soon, too. Thanks for review, @RealCLanger! Any other reviews, please, so I can push? ------------- PR Comment: https://git.openjdk.org/jdk/pull/13558#issuecomment-1516691879
