On Fri, 21 Apr 2023 07:51:00 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to 
>> a merge or a rebase. The pull request now contains one commit:
>> 
>>   JDK-8306658
>>   
>>   GHA: MSVC installation could be optional since it might already be 
>> pre-installed
>
> Okay, this sounds good to me. The synopsis is now incorrect, though: we do 
> not fail because the component was already installed, we fail because of the 
> backslashes. Suggestion: "GHA: MSVC installation should be skipped when it is 
> already installed".
> 
> I would still do the backslash change in a separate PR, because that thing 
> might change again in the future.

@shipilev Finished my PR-Limbo. Please (re-)review at your convenience.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13574#issuecomment-1517523865

Reply via email to