On Fri, 21 Apr 2023 06:56:43 GMT, Christoph Langer <clan...@openjdk.org> wrote:
> I did some more investigation for this issue. > > The real root cause for the failing install seems to be that the option > --installPath nowadays needs a correct Windows path with backslashes. This > probably must have been different beforehand. So I corrected that. > > However, as we figured that seemingly the correct toolchain could (and is) > already installed by default, it makes sense to skip the expensive > installation operation which takes some 10+ minutes in that case. > > I also tested the scenario with an older toolchain version which would need > installing, e.g. 14.28. Okay, this sounds good to me. The synopsis is now incorrect, though: we do not fail because the component was already installed, we fail because of the backslashes. Suggestion: "GHA: MSVC installation should be skipped when it is already installed". I would still do the backslash change in a separate PR, because that thing might change again in the future. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13574#pullrequestreview-1395264212
