On Fri, 21 Apr 2023 09:16:58 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains one commit: >> >> JDK-8306658 >> >> GHA: MSVC installation could be optional since it might already be >> pre-installed > > .github/workflows/build-windows.yml line 107: > >> 105: '/c/Program Files (x86)/Microsoft Visual >> Studio/2019/Enterprise/vc/auxiliary/build/vcvars64.bat' -vcvars_ver=${{ >> inputs.msvc-toolset-version }} >> 106: if [ $? -eq 0 ]; then >> 107: echo "Toolchain already installed" > > "is" Done. > .github/workflows/build-windows.yml line 110: > >> 108: echo "toolchain-installed=true" >> $GITHUB_OUTPUT >> 109: else >> 110: echo "Toolchain not yet installed" > > "is not" Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13574#discussion_r1173699221 PR Review Comment: https://git.openjdk.org/jdk/pull/13574#discussion_r1173699406