On Thu, 17 Aug 2023 01:01:02 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > put sizes back to uint32_t. Mostly okay. One change I'd like reverted. A few queries - in particular with the Elf file stuff it is hard to see how you decided the new sizes for some variables. Thanks. ------------- Changes requested by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15233#pullrequestreview-1581595070
