On Thu, 17 Aug 2023 12:24:48 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Wasting what?
>
> This calls move_position with the value next:
>
>
> bool DwarfFile::MarkedDwarfFileReader::move_position(const long offset) {
> if (offset == 0) {
> return true;
> }
> return set_position(_current_pos + offset);
> }
>
>
> Then set position
>
> bool FileReader::set_position(long offset) {
>
> Both will promote whatever "wasted type" to a long. I probably should make
> this a long though.
We're not using 'long' in platform dependent code but this elf support does use
it. That should be changed/fixed together if we decide to change/fix it.
Since this code isn't used on windows, maybe we don't mind the 'long' type here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1297153696
