On Thu, 17 Aug 2023 01:01:02 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > put sizes back to uint32_t. src/hotspot/share/utilities/elfFuncDescTable.cpp line 49: > 47: } > 48: > 49: address ElfFuncDescTable::lookup(Elf64_Addr index) { I think this could be `Elf_Addr` to be platform-specific. `Elf_Word` is either `Elf32_Word` or `Elf64_Word`, depending on the platform. But both are `typedefs` for `uint32_t` for some reason. That's why it must have complained here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296819904