On Tue, 21 Nov 2023 11:21:40 GMT, suchismith1993 <d...@openjdk.org> wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up with a list of symbols to allow math library symbols >> to be accesible. >> Also, there are parts of libc library that are static too, and hence those >> symbols also are present in this list. >> Without this change, the StdLibTest and multiple other tests which make >> native function calls using FFI, fail with NoSuchElementException. >> >> >> 1. Adding required compiler flags. >> 2. Adding required symbols. >> >> >> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) > > suchismith1993 has updated the pull request incrementally with 172 additional > commits since the last revision: > > - Provide support for math library in inline way. > - Symbol Resolution fix for Panama changes. > 1. Adding required compiler flags. > 2. Adding required symbols. > - 8320348: test/jdk/java/io/File/GetAbsolutePath.windowsDriveRelative fails > if working directory is not on drive C > > Reviewed-by: alanb, mbaesken > - 8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity > check failed > > Reviewed-by: alanb > - 8320234: Merge doclint.Env.AccessKind with tool.AccessKind > > Reviewed-by: jjg > - 8319817: Charset constructor should make defensive copy of aliases > > Reviewed-by: rriggs, alanb, bpb, iris, jpai > - 8320147: Remove DumpSharedSpaces > > Reviewed-by: ccheung, matsaave > - 8319973: AArch64: Save and restore FPCR in the call stub > > Reviewed-by: adinn, stuefe > - 8320410: Reflow markdown in building.md > > Reviewed-by: erikj > - 8319928: Exceptions thrown by cleanup actions should be handled correctly > > Reviewed-by: jvernee > - ... and 162 more: https://git.openjdk.org/jdk/compare/c340abf0...9c77fa98 It's messed up, now. Can you revert the last step? ------------- Changes requested by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16414#pullrequestreview-1741741189