On Tue, 21 Nov 2023 11:52:23 GMT, suchismith1993 <d...@openjdk.org> wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up with a list of symbols to allow math library symbols >> to be accesible. >> Also, there are parts of libc library that are static too, and hence those >> symbols also are present in this list. >> Without this change, the StdLibTest and multiple other tests which make >> native function calls using FFI, fail with NoSuchElementException. >> >> >> 1. Adding required compiler flags. >> 2. Adding required symbols. >> >> >> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) > > suchismith1993 has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Remove symbols file after using inline way. > - Provide support for math library in inline way. > - Update symbols-aix-foreign > > Remove comments from export list, causes build failures. > - Symbol Resolution fix for Panama changes. > 1.Adding required compiler flags. > 2. Adding required symbols. Nice! This solution looks better. But, please don't modify the shared version of syslookup.c. You can create one for AIX here: src/java.base/aix/native/libsyslookup ------------- Changes requested by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16414#pullrequestreview-1741796785
