On Thu, 30 Nov 2023 18:19:51 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not >> just CXXFLAGS? >> >> Also @vamsi-parasa, did you check into if this really was needed and why? To >> be clear, I basically consider this an integration blocker. > > Hi Magnus (@magicus), > The simdsort has a dependency on some C++ 17 features and would require a lot > of changes to avoid that. > Please see the latest code which removed the unused flags from CFLAGS. Raising the minimum gcc version is not done willy-nilly. (I feel a "You just don't ..." meme coming up) But you are saying that you want to skip building this library unless you have a gcc version that supports c++17? I still don't really like it. I'd like to hear someone else who can think clearly about this, if we want to go down this path, and start adding libraries that use C++17. Maybe @kimbarrett has some input? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1411206324
