On Thu, 30 Nov 2023 20:19:56 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> Raising the minimum gcc version is not done willy-nilly. (I feel a "You just >> don't ..." meme coming up) >> >> But you are saying that you want to skip building this library unless you >> have a gcc version that supports c++17? >> >> I still don't really like it. I'd like to hear someone else who can think >> clearly about this, if we want to go down this path, and start adding >> libraries that use C++17. Maybe @kimbarrett has some input? > >> But you are saying that you want to skip building this library unless you >> have a gcc version that supports c++17? >> > Yes, the request is to skip building the simdsort library if GCC version is < > 8 as only GCC >= 8 supports C++17 features. Then you must add logic to check for this. Now the build will just fail if building with an older gcc. That is not acceptable. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1413761798
