On Mon, 4 Dec 2023 11:48:44 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>>> But you are saying that you want to skip building this library unless you
>>> have a gcc version that supports c++17?
>>>
>> Yes, the request is to skip building the simdsort library if GCC version is
>> < 8 as only GCC >= 8 supports C++17 features.
>
> Then you must add logic to check for this. Now the build will just fail if
> building with an older gcc. That is not acceptable.
Hi Marcus (@magicus), please see the updated code which added guards to check
for GCC version >= 7.5 in
`src/java.base/linux/native/libsimdsort/{avx2-linux-qsort.cpp,
avx512-linux-qsort.cpp}`. GCC >= 7.5 is needed to compile libsimdsort using
C++17 features. Made sure that OpenJDK builds without errors using both GCC 7.5
and GCC 6.4.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1414570644
