On Mon, 15 Jan 2024 14:38:58 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> For gcc toolchains in ALLOW_ABSOLUTE_PATHS_IN_OUTPUT=False builds, this PR >> finds the location of the gcc system include paths, and adds >> -fdebug-prefix-map flags to map them to a standard location. Thus making the >> debuginfo and resulting libraries reproducible when using DevKits in >> different path locations. > > Andrew Leonard has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - 8323667: Library debug files contain non-reproducible full gcc include > paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> > - 8323667: Library debug files contain non-reproducible full gcc include > paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> > - Merge branch 'master' of github.com:openjdk/jdk into gcc_debug_map > - 8323667: Library debug files contain non-reproducible full gcc include > paths > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> make/autoconf/flags-cflags.m4 line 124: > 122: fi > 123: > 124: if test "x$DEBUG_PREFIX_CFLAGS" != x; then Should this test not be inside the "if $ALLOW_ABSOLUTE_PATHS_IN_OUTPUT == false" block? edit: Ah, I see, this is a consequence of the variables set in that if block. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17399#discussion_r1453366364
