On Tue, 16 Jan 2024 12:53:52 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - 8323667: Library debug files contain non-reproducible full gcc include >> paths >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> >> - 8323667: Library debug files contain non-reproducible full gcc include >> paths >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> >> - Merge branch 'master' of github.com:openjdk/jdk into gcc_debug_map >> - 8323667: Library debug files contain non-reproducible full gcc include >> paths >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > make/autoconf/flags-cflags.m4 line 194: > >> 192: # Add gcc system include mapping => /usr/local/gcc_include >> 193: # Find location of stddef.h using build C compiler >> 194: GCC_SYSTEM_INCLUDE=`$ECHO "#include <stddef.h>" | $CC >> $GCC_SYSROOT_PARAM -v -E - 2>&1 | $GREP stddef | $TAIL -1 | $TR -s " " | >> $CUT -d'"' -f2` > > Don't we have a properly setup `CFLAGS` here that you can use, instead of > having to specify the sysroot manually? Yeah, you're right, SYSROOT_CFLAGS ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17399#discussion_r1453428620
